Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: add ishidawataru/sctp as govendor dependency #1435

Conversation

idealhack
Copy link
Contributor

Ⅰ. Describe what this PR did

add ishidawataru/sctp as govendor dependency, using the latest version on master

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1435 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   38.72%   38.71%   -0.02%     
==========================================
  Files         254      254              
  Lines       16724    16724              
==========================================
- Hits         6477     6474       -3     
- Misses       9421     9422       +1     
- Partials      826      828       +2
Impacted Files Coverage Δ
daemon/containerio/container_io.go 59.74% <0%> (-1.3%) ⬇️
daemon/mgr/container.go 49.44% <0%> (-0.26%) ⬇️
daemon/logger/jsonfile/utils.go 70% <0%> (ø) ⬆️
ctrd/watch.go 78.12% <0%> (+3.12%) ⬆️

@idealhack idealhack changed the title refactor: add ishidawataru/sctp as govendor dependency [WIP] refactor: add ishidawataru/sctp as govendor dependency May 30, 2018
@fuweid
Copy link
Contributor

fuweid commented May 31, 2018

@idealhack , could you mind to add more description about this ishidawataru/sctp package, since we don't use this package? Thanks

@idealhack
Copy link
Contributor Author

idealhack commented May 31, 2018

@fuweid It's not a direct dependencies. I found this when I'm trying to vendoring libnetwork with govendor, I'm not sure about this so I added WIP to the title after I opened this PR.

@idealhack idealhack closed this May 31, 2018
@idealhack idealhack deleted the refactor/govendor/sctp branch May 31, 2018 10:12
@idealhack
Copy link
Contributor Author

Closed in favor of #1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants