Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: add docker/pkg/plugingetter as govendor dependency #1436

Conversation

idealhack
Copy link
Contributor

Ⅰ. Describe what this PR did

add docker/pkg/plugingetter as govendor dependency

using the same version as other docker packages (53a58da551e961b3710bbbdfabbc162c3f5f30f6)

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@idealhack Thanks for your contribution. 🍻
Please sign off in each of your commits.

@idealhack idealhack changed the title refactor: add docker/pkg/plugingetter as govendor dependency [WIP] refactor: add docker/pkg/plugingetter as govendor dependency May 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #1436 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   38.72%   38.66%   -0.06%     
==========================================
  Files         254      254              
  Lines       16724    16724              
==========================================
- Hits         6477     6467      -10     
- Misses       9421     9429       +8     
- Partials      826      828       +2
Impacted Files Coverage Δ
ctrd/image.go 76.57% <0%> (-2.86%) ⬇️
daemon/containerio/container_io.go 59.74% <0%> (-1.3%) ⬇️
ctrd/container.go 47.28% <0%> (-0.78%) ⬇️
daemon/mgr/network.go 68.3% <0%> (-0.5%) ⬇️
daemon/mgr/container.go 49.61% <0%> (-0.09%) ⬇️
daemon/logger/jsonfile/utils.go 71.66% <0%> (+1.66%) ⬆️

@idealhack idealhack closed this May 31, 2018
@idealhack idealhack deleted the refactor/govendor/docker branch May 31, 2018 10:11
@idealhack
Copy link
Contributor Author

Closed in favor of #1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants