Revert "hack.build: reduce the size of pouch and pouchd binaries" #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuanchang Thanks for your contribution. 🍻 |
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
=========================================
+ Coverage 40.75% 40.8% +0.05%
=========================================
Files 256 256
Lines 16756 16756
=========================================
+ Hits 6829 6838 +9
+ Misses 9048 9042 -6
+ Partials 879 876 -3
|
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1484
debug symbols also are removed by strip, although size of pouch and pouchd binaries are reduced, perhaps, we can append --only-keep-debug option to strip to avoid this issue later.