bugfix: release the container resources if contaienr failed to start #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Li <lcy041536@gmail.com>
HusterWan
reviewed
Jul 4, 2018
| @@ -444,6 +444,14 @@ func (mgr *ContainerManager) start(ctx context.Context, c *Container, detachKeys | |||
| if err == nil { | |||
| return | |||
| } | |||
|
|
|||
| // release the container resources(network and containerio) | |||
| err = mgr.releaseContainerResources(c) | |||
There was a problem hiding this comment.
if failed before prepareContainerNetwork, will always occur error here. WDTY??
There was a problem hiding this comment.
Yes, releaseContainerResources will still work. It will check the existence of network.
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
+ Coverage 41.96% 42.02% +0.05%
==========================================
Files 270 270
Lines 17597 17603 +6
==========================================
+ Hits 7385 7398 +13
+ Misses 9303 9298 -5
+ Partials 909 907 -2
|
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Li lcy041536@gmail.com
Ⅰ. Describe what this PR did
When the container failed to start, we should release the container resources, including network and containerio.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews