Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default option #615

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: default option #615

merged 1 commit into from
Apr 24, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Apr 24, 2024

No description provided.

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@l1b0k l1b0k requested a review from BSWANG April 24, 2024 09:55
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 23.08%. Comparing base (30f5f3b) to head (6d7699b).

Files Patch % Lines
pkg/aliyun/client/ecs_options.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   23.09%   23.08%   -0.02%     
==========================================
  Files          62       62              
  Lines        6382     6382              
==========================================
- Hits         1474     1473       -1     
- Misses       4670     4672       +2     
+ Partials      238      237       -1     
Flag Coverage Δ
unittests 23.08% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit ada08d8 into AliyunContainerService:main Apr 24, 2024
8 of 9 checks passed
@l1b0k l1b0k deleted the fix/err branch April 24, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants