New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaceholderWithoutTracking: removed default zero values for width and height props #58

Merged

Aljullu merged 1 commit into Aljullu:master from strashkov:default-size-fix

Apr 4, 2020

Contributor

strashkov commented Mar 3, 2020

As sizes can be set in class attribute (props className), we should not set the default values to zero


          PlaceholderWithoutTracking: removed default width and height values

a7ed28a

Aljullu approved these changes

View reviewed changes

Owner

Aljullu left a comment

Changes make sense. Thanks for working on this @strashkov.

Aljullu merged commit 2d52666 into Aljullu:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet