Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for sandbox to use the host network #1334

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

xingyaoww
Copy link
Contributor

This PR switch back to using --network=host as a default.

The --network=host is now supported with the newest version of Docker Desktop for MacOS - this was the only reason iirc that stopped us from using it before.

Version Docker Desktop 4.29.0
Settings ⇒ Features in development ⇒ Enable host networking
Host networking allows containers that are started with --net=host to use localhost to connect to TCP and UDP services on the host. It will automatically allow software on the host to use localhost to connect to TCP and UDP services in the container. Sign in required.

Enable host networking

Originally posted by @4-FLOSS-Free-Libre-Open-Source-Software in docker/roadmap#238 (comment)

@rbren rbren enabled auto-merge (squash) April 24, 2024 16:45
@rbren rbren merged commit fde0392 into All-Hands-AI:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants