Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOM and COGS generation examples #116

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

shrik450
Copy link
Collaborator

The functionality of these example scripts are redundant due to the BOM and COGS custom actions. Every time we make a change to these, we have to propagate that change to the actions repos as well. Further, their presence here only increases the likelihood of confusion and potential support burden.

Closes #104.

@shrik450 shrik450 requested a review from a team as a code owner May 16, 2024 22:30
Copy link
Contributor

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, there have already been changes in the custom actions repos that haven't been backported here.

@shrik450 shrik450 requested a review from kdumontnu May 20, 2024 15:31
@shrik450
Copy link
Collaborator Author

@danielallspice FYI

@danielallspice danielallspice self-requested a review May 20, 2024 16:51
Copy link
Collaborator

@danielallspice danielallspice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The functionality of these example scripts are redundant due to the
BOM and COGS custom actions. Every time we make a change to these, we
have to propagate that change to the actions repos as well. Further,
their presence here only increases the likelihood of confusion and
potential support burden.

See #104
@shrik450 shrik450 merged commit 2fd9b01 into main May 29, 2024
4 checks passed
@shrik450 shrik450 deleted the su/remove-examples branch May 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove generate_bom example scripts
3 participants