-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversation search and list to morph on refresh #581
Conversation
I just rechecked this PR, and it does fix an extra refresh that was happening after a new conversation is auto-titled. It's not too important, but feel free to reopen and apply this PR if desired. |
I like the idea of getting this fixed so I’ll probably merge it in. I noticed yesterday “main” is broken for my personal instance of hostedgpt. It’s so easy for bugs to slip in and I feel bad when it breaks for other people, so I just need to get a block of time where I can try this and the other pending PRs out and be careful about merging in. But I think this PR is a good idea so I’ll re-open just so it stays there on the list and I don’t forget about it. Sorry I’m slow on some of these. This holiday time-of-year is not helping my already busy schedule. :) |
This PR does fix the extra refresh, but now causes the cursor to jump to the beginning of the search input after every search, which is more annoying. I changed this to 'draft' and will look into it. |
Fixed cursor jumping, but now the X icon appears after every message. I'll look for better fix. Sorry for all the noise. |
@mattlindsey could you please fix it and commit for accept merge this pull? |
@buithehien1991 sorry this PR was blocked on me! thanks for flagging this, I've just fixed the dark mode issue and am merging it in. Thanks @mattlindsey ! |
I think this fixes problem with last PR that added searching, but I'm a little confused so better check it out.