fix: use chromeheadless not sandbox

reference: karma-runner/karma-chrome-launcher#158
AllanZhengYP · Jan 15, 2020 · a2f9810 · a2f9810
1 parent b1cde9b
commit a2f9810
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 10 deletions.
diff --git a/buildspec.yml b/buildspec.yml
@@ -6,6 +6,7 @@ phases:
       nodejs: 10
     commands:
       - npm install -g yarn
+      - curl https://intoli.com/install-google-chrome.sh | bash #TODO: install headless chrome to codebuild image
   build:
     commands:
       - echo Building...

diff --git a/package.json b/package.json
@@ -56,10 +56,8 @@
       "clients/*"
     ],
     "nohoist": [
-      "**/karma",
-      "**/karma/**",
-      "**/karma-*",
-      "**/karma-*/**"
+      "**/karma*",
+      "**/karma*/**"
     ]
   },
   "husky": {

diff --git a/packages/hash-blob-browser/karma.conf.js b/packages/hash-blob-browser/karma.conf.js
@@ -48,9 +48,13 @@ module.exports = function(config) {
     // enable / disable watching file and executing tests whenever any file changes
     autoWatch: false,
 
-    // start these browsers
-    // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-    browsers: ["ChromeHeadless"],
+    browsers: ["ChromeHeadlessNoSandbox"],
+    customLaunchers: {
+      ChromeHeadlessNoSandbox: {
+        base: "ChromeHeadless",
+        flags: ["--no-sandbox"]
+      }
+    },
 
     // Continuous Integration mode
     // if true, Karma captures browsers, runs the tests and exits

diff --git a/packages/hash-blob-browser/package.json b/packages/hash-blob-browser/package.json
@@ -4,7 +4,7 @@
   "scripts": {
     "prepublishOnly": "tsc",
     "pretest": "tsc",
-    "test": "karma start karma.conf.js"
+    "test": "karma start karma.conf.js --browsers ChromeHeadlessNoSandbox"
   },
   "main": "./build/index.js",
   "types": "./build/index.d.ts",

diff --git a/packages/stream-collector-browser/karma.conf.js b/packages/stream-collector-browser/karma.conf.js
@@ -8,7 +8,13 @@ module.exports = function(config) {
       "**/*.ts": "karma-typescript"
     },
     reporters: ["progress", "karma-typescript"],
-    browsers: ["ChromeHeadless"],
+    browsers: ["ChromeHeadlessNoSandbox"],
+    customLaunchers: {
+      ChromeHeadlessNoSandbox: {
+        base: "ChromeHeadless",
+        flags: ["--no-sandbox"]
+      }
+    },
     karmaTypescriptConfig: {
       tsconfig: "./tsconfig.json",
       bundlerOptions: {

diff --git a/packages/stream-collector-browser/package.json b/packages/stream-collector-browser/package.json
@@ -5,7 +5,7 @@
   "scripts": {
     "prepublishOnly": "tsc",
     "pretest": "tsc -p tsconfig.json",
-    "test": "karma start karma.conf.js"
+    "test": "karma start karma.conf.js --browsers ChromeHeadlessNoSandbox"
   },
   "author": {
     "name": "AWS SDK for JavaScript Team",