Sync updated configs from primary master to standby master and worker #17850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiacheliu3 can you please help take a look? thanks |
jiacheliu3
reviewed
Aug 4, 2023
| * @param <K> the type of keys maintained by this map | ||
| * @param <V> the type of mapped values | ||
| */ | ||
| public class FixedSizeTreeMap<K, V> extends TreeMap<K, V> { |
| public void heartbeat(long timeLimitMs) throws InterruptedException { | ||
| if (Configuration.getBoolean(PropertyKey.CONF_SYNC_HEARTBEAT_ENABLED)) { | ||
| try { | ||
| Configuration.applyUpdatedConf(mClient.getConfAddress()); |
There was a problem hiding this comment.
do not send rpc in this Configuration class
jiacheliu3
reviewed
Aug 4, 2023
| * @param version a version to filter the updated configurations | ||
| * @return the updated properties after the given version | ||
| */ | ||
| Pair<List<Map<String, String>>, Long> getUpdatedConfiguration(long version); |
There was a problem hiding this comment.
let's define an obj for this complicated data structure
…es and last version
alluxio-bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
### What changes are proposed in this pull request? Fix to support update new key, for example, template key. This is the dependency order. so we can review the bottom one first. #17305 ↓ #17780 ↓ #17850 ↓ #17856 ### Why are the changes needed? Without this PR, we cannot update template key or any other key didn't exist in PropertyKeys. ### Does this PR introduce any user facing changes? No. pr-link: #17856 change-id: cid-5caa981f178aa3581cd49ed845e3ebbfa6214a15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including