Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set min replicate to 0 and unpin file if we fail to replicate a file #17865

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Set min replicate to 0 and unpin file if we fail to replicate a file #17865

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b51e59c
Unpin a file and set min replicate to 0 if we fail to replicate a file.
yuzhu Jul 31, 2023
cc4b64f
Address comment
yuzhu Jul 31, 2023
9af7a94
Address comment
yuzhu Jul 31, 2023
f46d5c1
Add a comment on the side effect
yuzhu Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions job/server/src/main/java/alluxio/job/plan/replicate/SetReplicaDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import alluxio.conf.Configuration;
import alluxio.exception.status.NotFoundException;
import alluxio.grpc.RemoveBlockRequest;
import alluxio.grpc.SetAttributePOptions;
import alluxio.job.RunTaskContext;
import alluxio.job.SelectExecutorsContext;
import alluxio.job.plan.AbstractVoidPlanDefinition;
Expand All @@ -37,6 +38,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.util.Collections;
import java.util.List;
import java.util.Set;
Expand Down Expand Up @@ -168,8 +170,25 @@ private void replicate(SetReplicaConfig config, RunTaskContext context) throws E
// to avoid the the race between "replicate" and "rename", so that even a file to replicate is
// renamed, the job is still working on the correct file.
URIStatus status = context.getFileSystem().getStatus(new AlluxioURI(config.getPath()));

JobUtils.loadBlock(status, context.getFsContext(), config.getBlockId(), null, false);
try {
JobUtils.loadBlock(status, context.getFsContext(), config.getBlockId(), null, false);
} catch (IOException e) {
// This will remove the file from the pinlist if it fails to replicate, there can be false
// positives because replication can fail transiently and this would unpin it. However,
// compared to repeatedly replicating, this is a more acceptable result.
LOG.warn("Replication of {} failed, reduce min replication to 0 and unpin. Reason: {} ",
status.getPath(), e.getMessage());
SetAttributePOptions.Builder optionsBuilder =
SetAttributePOptions.newBuilder();
try {
context.getFileSystem().setAttribute(new AlluxioURI(config.getPath()),
optionsBuilder.setReplicationMin(0).setPinned(false).build());
} catch (Throwable e2) {
e.addSuppressed(e2);
Copy link
Contributor

@apc999 apc999 Jul 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add LOG.warn here so at least we can find this suppressed issues in logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

LOG.warn("Attempt to set min replication to 0 and unpin failed due to ", e2);
}
throw e;
}
LOG.info("Replicated file " + config.getPath() + " block " + config.getBlockId());
}
}
Loading