Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zookeeper related code #18038

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Remove zookeeper related code #18038

wants to merge 8 commits into from

Conversation

yuzhu
Copy link
Contributor

@yuzhu yuzhu commented Aug 21, 2023

What changes are proposed in this pull request?

With 3.0 architecture, Zookeeper related leader election functionality is no longer needed. This is a first attempt to remove most of the zookeeper dependency from the code base.

Does this PR introduce any user facing changes?

Removal of zookeeper dependency and the ability to use it to elect a leader.

@yuzhu yuzhu marked this pull request as ready for review August 23, 2023 17:18
@yuzhu
Copy link
Contributor Author

yuzhu commented Aug 23, 2023

still fixing some tests, but welcome high level comments

@yuzhu
Copy link
Contributor Author

yuzhu commented Sep 5, 2023

@apc999 @jiacheliu3 PTAL thanks.

@cosminnicula
Copy link

Hey @yuzhu, by the looks of this PR, the code changes should clear the path toward removing the org.apache.zookeeper:zookeeper dependencies from all the pom.xml files.

If this holds true, then I have a few questions:

  1. shouldn't this PR also clean up all the pom.xml files? (e.g. remove all org.apache.zookeeper:zookeeper dependencies from all the pom.xml files)
  2. was there any real workload testing and validation that used a tarball published with these changes?
  3. is there any chance to port these changes to the 2.x branch?

I'm asking all this in the context of the critical log4j 1.x vulnerabilities that are currently introduced by the org.apache.zookeeper:zookeeper:3.5.5 dependency. Removing ZooKeeper altogether would definitely help, alongside this PR #17002 which bumps hadoop from 3.3.1 to 3.3.4 (hadoop 3.3.1 was another source of critical log4j 1.x vulnerabilities).

I might be able to provide some help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants