Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with unsupported message when GetBucketLocation #18416

Merged

Conversation

Jackson-Wang-7
Copy link
Contributor

What changes are proposed in this pull request?

Respond with unsupported message when GetBucketLocation

Why are the changes needed?

Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

Copy link
Contributor

@lucyge2022 lucyge2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackson-Wang-7 Jackson-Wang-7 added the type-bug This issue is about a bug label Nov 16, 2023
@Jackson-Wang-7
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit d8fdcb5 into Alluxio:master-2.x Nov 16, 2023
17 checks passed
@Jackson-Wang-7
Copy link
Contributor Author

alluxio-bot, cherry-pick this to branch-2.8 please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-2.8 successfully opened PR: #18432

alluxio-bot pushed a commit that referenced this pull request Nov 21, 2023
### What changes are proposed in this pull request?
Respond with unsupported message when GetBucketLocation

### Why are the changes needed?
Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

			pr-link: #18416
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
@Jackson-Wang-7
Copy link
Contributor Author

alluxio-bot, cherry-pick this to branch-2.10 please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-2.10 successfully opened PR: #18433

alluxio-bot pushed a commit that referenced this pull request Nov 21, 2023
### What changes are proposed in this pull request?
Respond with unsupported message when GetBucketLocation

### Why are the changes needed?
Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

			pr-link: #18416
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
alluxio-bot added a commit that referenced this pull request Nov 22, 2023
Cherry-pick of existing commit.
orig-pr: #18416
orig-commit: d8fdcb5
orig-commit-author: yuyang wang <39869597+Jackson-Wang-7@users.noreply.github.com>

			pr-link: #18433
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
alluxio-bot added a commit that referenced this pull request Nov 22, 2023
Cherry-pick of existing commit.
orig-pr: #18416
orig-commit: d8fdcb5
orig-commit-author: yuyang wang <39869597+Jackson-Wang-7@users.noreply.github.com>

			pr-link: #18432
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
maobaolong pushed a commit to maobaolong/alluxio that referenced this pull request Jan 3, 2024
### What changes are proposed in this pull request?
Respond with unsupported message when GetBucketLocation

### Why are the changes needed?
Alluxio proxy doesn't support GetBucketLocation request, so we need to return 'Not Implemented' error code.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

			pr-link: Alluxio#18416
			change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants