Load content hash as the etag of the object when the UFS is S3 #18440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elega
approved these changes
Nov 24, 2023
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
Jackson-Wang-7
changed the title
|
Automated checks report:
All checks passed! |
|
alluxio-bot, merge this please |
|
alluxio-bot, cherry-pick this to branch-2.10 please |
|
Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick 91e045b cannot be auto cherry-picked to branch branch-2.10. Please cherry-pick this manually. |
Jackson-Wang-7
added a commit
to Jackson-Wang-7/alluxio
that referenced
this pull request
Nov 27, 2023
Recode the content hash into XAttr as the ETag when the UFS is S3. When the file is newly created or loaded from UFS, Alluxio will record the ContentHash into metastore so the user can see the ETag attribute. When the UFS is Object storage, The user can see the ETag of the file persisted in UFS by this way. No pr-link: Alluxio#18440 change-id: cid-1204732240a5e73959b917eb6d9f0c97e05820dc
Jackson-Wang-7
added a commit
to Jackson-Wang-7/alluxio
that referenced
this pull request
Nov 28, 2023
Cherry-pick of existing commit. orig-pr: Alluxio#18440 orig-commit: Alluxio/alluxio@91e045b orig-commit-author: yuyang wang <39869597+Jackson-Wang-7@users.noreply.github.com> pr-link: Alluxio#18446 change-id: cid-1204732240a5e73959b917eb6d9f0c97e05820dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Recode the content hash into XAttr as the ETag when the UFS is S3. When the file is newly created or loaded from UFS, Alluxio will record the ContentHash into metastore so the user can see the ETag attribute.
Why are the changes needed?
When the UFS is Object storage, The user can see the ETag of the file persisted in UFS by this way.
Does this PR introduce any user facing changes?
No