Fix data corrupted issue when loading from UFS #18564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A this fix a bug in corrupted data files. Previously, Alluxio#17497 attempt to solve this issue but only covers the case when creating a UFS reader Notice we only handle block reader. So this may not fix `paged Block Reader` in 2.x Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, describe the bug. Please list the user-facing changes introduced by your change, including 1. change in user-facing APIs 2. addition or removal of property keys 3. webui pr-link: Alluxio#18525 change-id: cid-bbba0feb29231e70750e5e79da5f405bb591d47a
jja725
reviewed
Apr 1, 2024
| * @return metadata of the block or null if the temp block does not exist | ||
| */ | ||
| @Nullable | ||
| TempBlockMeta getTempBlockMeta(long sessionId, long blockId); |
There was a problem hiding this comment.
I actually not sure we want to change the interface here, we better just update the place we invoke the method?
There was a problem hiding this comment.
many places, we do not have a reference to the sessionId, that's why I changed it..
| * @param blockId the id of the block | ||
| * @return metadata of the block or null if the temp block does not exist | ||
| */ | ||
| @Nullable | ||
| TempBlockMeta getTempBlockMeta(long sessionId, long blockId); |
jja725
approved these changes
Apr 2, 2024
|
alluxio.master.journal.raft.SnapshotReplicationManagerTest not related to the changes |
|
alluxio-bot, force-merge this please |
|
merge failed: |
|
alluxio-bot, force-merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in corrupted data files.
Previously, #17497 attempt to solve this issue but only covers the case when creating a UFS reader Notice we only handle block reader. So this may not fix
paged Block Readerin 2.xPlease clarify why the changes are needed. For instance,
Please list the user-facing changes introduced by your change, including
change in user-facing APIs
addition or removal of property keys
webui
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including