Support more configuration in TOS #18628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static TransportConfig initializeTOSClientConfig( | ||
| AlluxioConfiguration alluxioConf) { | ||
| int readTimeoutMills = (int) alluxioConf.getMs(PropertyKey.UNDERFS_TOS_READ_TIMEOUT); |
There was a problem hiding this comment.
if you want to use alluxioConf.getMs, use the durationBuilder instead of intBuilder.
if you use the intBuilder, please use getInt.
|
alluxio-bot, merge this please |
Xenorith
pushed a commit
that referenced
this pull request
Jun 24, 2024
### What changes are proposed in this pull request? This update includes several configuration options for TOS and adds the functionality to clean up expired redundant multipart upload files. ### Why are the changes needed? 1. Previously, users could not specify the number of threads, timeout durations, etc. Now, all these options can be configured when connecting to TOS. 2. Fixed the issue where expired files were not automatically cleaned up. ### Does this PR introduce any user facing changes? There are now more configuration options available, which need to be specified in the conf file. pr-link: #18628 change-id: cid-53fa0171172eed54edb077b8af0d1d62b23d7bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This update includes several configuration options for TOS and adds the functionality to clean up expired redundant multipart upload files.
Why are the changes needed?
Does this PR introduce any user facing changes?
There are now more configuration options available, which need to be specified in the conf file.