Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics when cache miss #18698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jja725
Copy link
Contributor

@jja725 jja725 commented Sep 26, 2024

What changes are proposed in this pull request?

Fix metrics when there's cache miss

Why are the changes needed?

The correct behavior should be

  1. When read from external storage (or a cache miss?),
    CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS == 0 & CLIENT_CACHE_PAGE_READ_EXTERNAL_TIME_NS > 0

  2. When read from cache (or cache hit?),
    CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS > 0 & CLIENT_CACHE_PAGE_READ_EXTERNAL_TIME_NS == 0

Does this PR introduce any user facing changes?

na

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • Title must not end with whitespace
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@jja725 jja725 changed the title Fix metrics when cache miss Fix metrics when cache miss Sep 26, 2024
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants