[WIP] Move from notify blacklist to announcement mute role #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies MiscUtils.announce() to also revoke write permission from a special announce mute role. It also moves a lot of static hardcoded IDs for entities + some entity getters to a common EntityLookup class (name subject to change). TODO: Create Role and fill in ID in EntityLookup
Almighty-Alpaca
changed the title
|
On hold until open questions are resolved and all other open PRs are merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still WIP
Description
Removes the notify blacklist previously used and instead adds an announcment mute role.
This allows users to actually get notified about announcements but prevents them from spamming by revoking their WRITE permission.
This PR builds on the previously merged PR #29 , which added
MiscUtil.announce(...)Todo
Below is a list of actually known Todo entries. Since this is still a WIP, there might be some significant changes to how everything works tho and the Todo list will update correspondingly.
EntityLookup.EntityLookup. When i wrote the initial commit, i couldn't come up with a better name.