fix: update time-rs crate #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Rust 1.80.0 broke `time-rs` <0.3.35][1]. We have it locked to v0.3.34 which is affected. Running `cargo update time` fixes this issue. [1]: rust-lang/rust#127343
jalil-salame
added a commit
to jalil-salame/configuration.nix
that referenced
this pull request
Aug 16, 2024
Known issue, it won't be fixed. Programs just need to update to a new version of `time-rs` (the affected dep). Waiting for Aloxaf/silicon#254 to land so I can remove the dependency on the old version.
|
I love silicon, but currently have to comment it out of my nix config, lets get this merged! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.80.0 broke
time-rs<0.3.35. We have it locked to v0.3.34 which is affected.Running
cargo update timefixes this issue.Pushing a new version after this update would be nice. That way we can pull the fix downstream c: