Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC v1] Fixed signTypedData_v4 routing #3141

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

justindg
Copy link
Contributor

@justindg justindg commented Mar 9, 2023

eth_signTypedData_v4 messages are not routed properly because of a missing enum, hence the signing dialog does not appear.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
7
▀▀▀▀
3h 13m
4
▀▀▀▀
JamesSmartCell
🥈
8
▀▀▀▀
19h 31m
▀▀▀▀▀▀▀▀
4
▀▀▀▀
justindg
🥉
4
▀▀
20m
2
▀▀

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 25.00% and no project coverage change.

Comparison is base (45f49b7) 7.67% compared to head (5f0ade0) 7.68%.

❗ Current head 5f0ade0 differs from pull request most recent head 93fb730. Consider uploading reports for the commit 93fb730 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3141   +/-   ##
========================================
  Coverage      7.67%   7.68%           
  Complexity      902     902           
========================================
  Files           653     653           
  Lines         44173   44176    +3     
  Branches       4454    4455    +1     
========================================
+ Hits           3392    3394    +2     
- Misses        40493   40494    +1     
  Partials        288     288           
Impacted Files Coverage Δ
...main/java/com/alphawallet/app/ui/HomeActivity.java 2.36% <0.00%> (-0.01%) ⬇️
...allet/app/walletconnect/AWWalletConnectClient.java 6.70% <0.00%> (ø)
...java/com/alphawallet/app/walletconnect/WCClient.kt 0.00% <ø> (ø)
.../com/alphawallet/app/walletconnect/entity/Enums.kt 85.71% <100.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JamesSmartCell JamesSmartCell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need a route for eth_signTypedData_v3 ?

@JamesSmartCell JamesSmartCell self-requested a review March 13, 2023 04:50
@JamesSmartCell JamesSmartCell merged commit cf609cb into master Mar 13, 2023
@JamesSmartCell JamesSmartCell deleted the 3139-fix-v4-typed-data-routing branch March 13, 2023 04:50
seabornlee pushed a commit that referenced this pull request Mar 15, 2023
* Fixed signTypedData_v4 routing
* Add signTypedData_v3 to parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants