Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC1559 Enabled by default #3265

Merged
merged 2 commits into from
Aug 9, 2023
Merged

ERC1559 Enabled by default #3265

merged 2 commits into from
Aug 9, 2023

Conversation

pratikmhatre
Copy link
Contributor

@pratikmhatre pratikmhatre commented Aug 1, 2023

Solves : #3202

  1. 1559 Transactions will be enabled by default.
  2. Experimental subtitle is hidden from 1559 Transactions in advanced settings.

File: SharedPreferenceRepository.java

# Original Code
@Override
    public boolean getUse1559Transactions()
    {
        return pref.getBoolean(EXPERIMENTAL_1559_TX, false);
    }
#Modified Code
@Override
    public boolean getUse1559Transactions()
    {
        return pref.getBoolean(EXPERIMENTAL_1559_TX, true);
    }

@JamesSmartCell
Copy link
Member

Thanks @pratikmhatre! Been needing to add this in for a while.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (834b05b) 7.41% compared to head (93895d8) 7.41%.

❗ Current head 93895d8 differs from pull request most recent head 3fb9b40. Consider uploading reports for the commit 3fb9b40 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3265   +/-   ##
========================================
  Coverage      7.41%   7.41%           
  Complexity      907     907           
========================================
  Files           672     672           
  Lines         46257   46256    -1     
  Branches       4675    4675           
========================================
  Hits           3430    3430           
+ Misses        42531   42530    -1     
  Partials        296     296           
Files Changed Coverage Δ
...let/app/repository/SharedPreferenceRepository.java 30.00% <0.00%> (ø)
...m/alphawallet/app/ui/AdvancedSettingsActivity.java 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JamesSmartCell JamesSmartCell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks :)

@JamesSmartCell JamesSmartCell added this pull request to the merge queue Aug 9, 2023
Merged via the queue into AlphaWallet:master with commit d478df3 Aug 9, 2023
5 checks passed
@pratikmhatre pratikmhatre deleted the erc1559_default_on branch August 9, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants