Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DappBrowser history #3277

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix DappBrowser history #3277

merged 1 commit into from
Aug 28, 2023

Conversation

JamesSmartCell
Copy link
Member

Fixes issue reported on Discord, where user was unable to edit an old URL of a site and kept going to the old one.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
2
▀▀▀▀▀▀▀▀▀▀
8d 18h 42m
▀▀▀▀▀▀▀▀▀▀
0

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 10.63% and project coverage change: -0.01% ⚠️

Comparison is base (ea5bc7f) 7.36% compared to head (038f307) 7.36%.
Report is 1 commits behind head on master.

❗ Current head 038f307 differs from pull request most recent head 52e58e1. Consider uploading reports for the commit 52e58e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3277      +/-   ##
===========================================
- Coverage      7.36%   7.36%   -0.01%     
  Complexity      909     909              
===========================================
  Files           675     675              
  Lines         46824   46833       +9     
  Branches       4751    4753       +2     
===========================================
- Hits           3449    3448       -1     
- Misses        43073   43083      +10     
  Partials        302     302              
Files Changed Coverage Δ
...com/alphawallet/app/ui/BrowserHistoryFragment.java 0.00% <0.00%> (ø)
...in/java/com/alphawallet/app/widget/AddressBar.java 15.82% <0.00%> (-1.38%) ⬇️
...ava/com/alphawallet/app/util/DappBrowserUtils.java 21.66% <5.26%> (-1.15%) ⬇️
.../widget/adapter/DappBrowserSuggestionsAdapter.java 16.12% <6.25%> (+1.84%) ⬆️
...c/main/java/com/alphawallet/app/web3/Web3View.java 19.85% <100.00%> (+1.74%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesSmartCell JamesSmartCell merged commit e6304bd into master Aug 28, 2023
7 checks passed
@JamesSmartCell JamesSmartCell deleted the dappbrowser-history-edit branch August 28, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant