Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project and add tests. #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IgorGanapolsky
Copy link

Update library versions.
Fix gitignore file.

Add Espresso test for RangingActivity.
Lint and refactor RangingActivity.
Format code.

Update library versions.
Fix gitignore file.

Add Espresso test for RangingActivity.
Lint and refactor RangingActivity.
Format code.
@davidgyoung
Copy link
Member

Thanks, @IgorGanapolsky. I appreciate the upgrades.

Two thoughts:

  1. I'd like to wait until release versions are available before upgrading to gradle 4.x and gradle tools 3.x

  2. The reference application is designed to be as simple of an app as possible that demonstrates the core features of the library. Given this goal, does an espresso test really make sense?

@IgorGanapolsky
Copy link
Author

@davidgyoung IMO code coverage makes sense in any app. Otherwise it becomes legacy code, and more difficult to refactor later. Also, the fix of .gitignore as well as Lint corrections make the project easier to maintain and more testable.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants