Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "system_replicas_is_session_expired" metric to the exporter. #187

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

teralype
Copy link
Contributor

This metric reports which replicated tables have seen their Zookeeper sessions expired. This metric is labeled by database and table, plus additional labels that are added by default (e.g. ClickHouse hostname).

Expired Zookeeper sessions cause ClickHouse to start switching tables to read/only which is likely a symptom that something is wrong with Zookeeper or the network itself. In general, when this happens, the operator needs to take action in order to fix this situation.

This metric reports which replicated tables have seen their Zookeeper
sessions expired. This metric is labeled by database and table, plus
additional labels that are added by default (e.g. ClickHouse hostname).
This metric reports which replicated tables have seen their Zookeeper
sessions expired. This metric is labeled by database and table, plus
additional labels that are added by default (e.g. ClickHouse hostname).
@teralype teralype changed the title Add the "metric.IsSessionExpired" metric to the exporter. Add the "system_replicas_is_session_expired" metric to the exporter. Oct 24, 2019
@teralype
Copy link
Contributor Author

@alex-zaitsev mind taking a look at this? I think this is an interesting addition to the ClickHouse operator. I've also taken the liberty to clean up the code a little bit.

Copy link
Member

@alex-zaitsev alex-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@sunsingerus sunsingerus merged commit 185a43b into Altinity:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants