Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force reload when user has changed reportee in another tab #1134

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

allinox
Copy link
Contributor

@allinox allinox commented Oct 30, 2024

Description

This PR introduces a check on the value of the cookie AltinnPartyId (which later will be changed to AltinnPartyUuid) so as to force a reload if the value changes due to a change in reportee in a different tab.
The user is informed that the reload is to be happening with an alert.

This will hopefully solve the issue of possibly delegating something on behalf of a different party than intended which could potentially happen if the reportee is changed in one tab while performing a delegation in another without the GUI being updated.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Oct 30, 2024
@allinox allinox requested a review from sonwit October 30, 2024 13:29
Copy link
Contributor

@sonwit sonwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few comments.

I'll approve this and you can merge when you are ready. 👍🏼

@allinox allinox merged commit d292bd1 into main Oct 31, 2024
4 checks passed
@allinox allinox deleted the feat/1133-authentication-with-multible-tabs branch October 31, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants