Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of Virus-scan result in Altinn 3 for Status in Altinn 3 and Altinn 2 #409

Closed
3 tasks done
tomshag opened this issue Apr 26, 2024 · 3 comments
Closed
3 tasks done

Handling of Virus-scan result in Altinn 3 for Status in Altinn 3 and Altinn 2 #409

tomshag opened this issue Apr 26, 2024 · 3 comments
Assignees
@tomshag

Comments

@tomshag
Copy link
Contributor

tomshag commented Apr 26, 2024 •
edited
Loading

Når en file feiler i Altinn 3 pga. virus scanning, og vi så henter status i Altinn 2, så får vi status "File Deleted".
Dette gir avsender og mottaker feil ide om hva som har skjedd.
Tar en analyse av følgende.

Tasks
Preview Give feedback
@tomshag tomshag converted this from a draft issue Apr 26, 2024
@tomshag tomshag self-assigned this Apr 26, 2024
@tomshag
Copy link
Contributor Author

tomshag commented Apr 29, 2024 •
edited
Loading

Task 1-
Når Status på virus-scanning er "Virus funnet" eller lignende, altså failed, gis fil først status "Failed" i FileTranferStatusrepository.
Deretter legges det en kø-jobb for å "Expire" fila til ExpireFileTransferHandler.
Her blir fila så slettet og status settes til "Slettet" i FileTransferStatusRepository. Dette skjer som sitt eget kall.
Foreslått endring: En ny variabel i ExpireFileTransferCommandRequest som gjør det klart at fil skal "Expires" pga. feil under behandling, og derfor ikke skal gi status "Deleted", siden dette er en status som settes for filer som har gått igjennom hele Broker processen. (Altså lastet opp, behandlet, published, lastet ned og så evt. expired.)

I alle disse tilfellene gjøres det også en AltinnEventType Publish kall for UploadFailed og FileDeleted.
Jeg antar at disse skal fungere på samme måte, altså at fil skal enten gis status Failed elller Deleted, men ikke begge.

@tomshag tomshag moved this from 📋 Backlog to 🏗 In progress in Altinn melding og formidling Apr 29, 2024
tomshag pushed a commit that referenced this issue Apr 30, 2024
Updated code better handle malware scan errors so that endusers can b…
b0140c1 
…e better informed about their upload results.

#409
@tomshag tomshag mentioned this issue Apr 30, 2024
Merged
5 tasks
@tomshag
Copy link
Contributor Author

tomshag commented Apr 30, 2024

Pull request opprettet for endring basert på mail korrespondanse

tomshag added a commit that referenced this issue May 2, 2024
@tomshag
Updated code better handle malware scan errors so that endusers can b… (
b5eb74b 
#412)

* Updated code better handle malware scan errors so that endusers can be better informed about their upload results.
#409

* Dotnet format + changed Deleted references to purged

---------

Co-authored-by: tsh <acn-thage@ai-dev.no>
@tomshag tomshag mentioned this issue May 6, 2024
Merged
5 tasks
@tomshag
Copy link
Contributor Author

tomshag commented May 8, 2024

Handling of Altinn 2 code is now updated and returns full malwar error.

@tomshag tomshag closed this as completed May 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Altinn melding og formidling May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomshag tomshag

Labels
None yet
Projects
Altinn melding og formidling
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomshag