Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LegacyFileController.GetFileOverview #288

Merged
merged 12 commits into from
Jan 26, 2024

Conversation

RagnarFatland-Avanade
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade commented Jan 25, 2024

Description

Added LegacyFileController.GetFileOverview and associated External Entities to be used by Broker Legacy solution.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Ragnar Inge Fatland and others added 10 commits January 18, 2024 18:16
Unit test fails with 401 - probably due to Legacy token not being signed correctly.
It still fails with error 500 if I hack the auth to use sender:
The error happens in the return stage on line 85. MapToExternalModel seems to function so unsure as to why.
Unit test fails with 401 - probably due to Legacy token not being signed correctly.
It still fails with error 500 if I hack the auth to use sender:
The error happens in the return stage on line 85. MapToExternalModel seems to function so unsure as to why.
…ileOverviewExt json serialization.

Added ResorceID mapping to external File Overview entities.
Ragnar Inge Fatland added 2 commits January 26, 2024 10:14
Moved access check override for legacy users into ResourceRightsRepository to centralize check and future duplication of code.
Copy link
Collaborator

@Ceredron Ceredron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Good call using optional parameter for CheckUserAccess.

@RagnarFatland-Avanade RagnarFatland-Avanade merged commit 9533b99 into main Jan 26, 2024
1 check passed
@RagnarFatland-Avanade RagnarFatland-Avanade deleted the Feature/BrokerLegacy-GetFileOverview branch January 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants