-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LegacyFileController.GetFileOverview #288
Merged
RagnarFatland-Avanade
merged 12 commits into
main
from
Feature/BrokerLegacy-GetFileOverview
Jan 26, 2024
Merged
Added LegacyFileController.GetFileOverview #288
RagnarFatland-Avanade
merged 12 commits into
main
from
Feature/BrokerLegacy-GetFileOverview
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…authorization settings for Legacy.
Unit test fails with 401 - probably due to Legacy token not being signed correctly. It still fails with error 500 if I hack the auth to use sender: The error happens in the return stage on line 85. MapToExternalModel seems to function so unsure as to why.
…authorization settings for Legacy.
Unit test fails with 401 - probably due to Legacy token not being signed correctly. It still fails with error 500 if I hack the auth to use sender: The error happens in the return stage on line 85. MapToExternalModel seems to function so unsure as to why.
….com/altinn/altinn-broker into Feature/BrokerLegacy-GetFileOverview
…ileOverviewExt json serialization. Added ResorceID mapping to external File Overview entities.
Ceredron
reviewed
Jan 26, 2024
src/Altinn.Broker.Application/GetFileOverviewQuery/GetFileOverviewQueryHandler.cs
Outdated
Show resolved
Hide resolved
Moved access check override for legacy users into ResourceRightsRepository to centralize check and future duplication of code.
Ceredron
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Good call using optional parameter for CheckUserAccess.
RagnarFatland-Avanade
deleted the
Feature/BrokerLegacy-GetFileOverview
branch
January 26, 2024 09:39
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added LegacyFileController.GetFileOverview and associated External Entities to be used by Broker Legacy solution.
Related Issue(s)
Verification
Documentation