Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum validation #298

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Checksum validation #298

merged 6 commits into from
Feb 6, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Feb 5, 2024

Description

We should verify the integrity of uploaded files using a checksum. If no checksum is given, we should store the checksum regardless to enable recipients to verify that file has not been tampered with while at rest.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review February 5, 2024 16:13
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ceredron Ceredron merged commit 89c286e into main Feb 6, 2024
1 check passed
@Ceredron Ceredron deleted the feature/md5-checksum-validation branch February 6, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants