Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed from Maskinporten token to Altinn token #304

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Changed from Maskinporten token to Altinn token #304

merged 3 commits into from
Feb 15, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Feb 9, 2024 •
edited
Loading

Description

In order to call other Altinn API's we need to use an Altinn token instead of Maskinporten token.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review February 13, 2024 14:09
RagnarFatland-Avanade
RagnarFatland-Avanade reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please consider updating the tokens used in the unit tests to reflect the new AltinnToken being used.

@Ceredron
Copy link
Collaborator Author

Looks good, but please consider updating the tokens used in the unit tests to reflect the new AltinnToken being used.

Fixed in resource register PR
dc9c43e

@Ceredron Ceredron merged commit 83c492c into main Feb 15, 2024
1 check passed
@Ceredron Ceredron deleted the chore/altinn-test-token branch February 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RagnarFatland-Avanade RagnarFatland-Avanade RagnarFatland-Avanade left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ceredron @RagnarFatland-Avanade