Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resource upload size #352

Merged
merged 22 commits into from
Mar 12, 2024
Merged

Feature/resource upload size #352

merged 22 commits into from
Mar 12, 2024

Conversation

Andreass2
Copy link
Collaborator

@Andreass2 Andreass2 commented Mar 11, 2024

Description

  • Global max filetransfer size

  • Customizable max size on resource level. if null, it uses the global maximum.

  • Added tests for new endpoint

  • We previously looked up the resource from the resourceRegistry each time it was needed. Now we store it the first time its used, and then we load it locally, which will probably give a small performance boost.

  • I added the global max as an environment variable, meaning we can just create a new replica of a container app in azure to change it. Another solution I considered was to store the value in the database, but discarded it as I think the global max will seldom change.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Andreass2 Andreass2 merged commit a3d90b8 into main Mar 12, 2024
1 check passed
@Andreass2 Andreass2 deleted the feature/resource-upload-size branch March 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants