Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling of non-existing resource #436

Merged
merged 5 commits into from
May 22, 2024
Merged

Fixed handling of non-existing resource #436

merged 5 commits into from
May 22, 2024

Conversation

Ceredron
Copy link
Collaborator

Description

Resource registry returns NoContent when resourceId does not exist. This should be handled as not found.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Ceredron added 2 commits May 15, 2024 10:01
Andreass2
Andreass2 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ceredron Ceredron merged commit 10e67e9 into main May 22, 2024
4 checks passed
@Ceredron Ceredron deleted the fix/proper-handling-of-unknown-resourceId branch May 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreass2 Andreass2 Andreass2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ceredron @Andreass2