Move exception handling to filter

Altinn · Nov 28, 2023 · 91818f3 · 91818f3
1 parent 1206f0f
commit 91818f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/backend/src/Designer/Filters/Git/GitExceptionFilterAttribute.cs b/backend/src/Designer/Filters/Git/GitExceptionFilterAttribute.cs
@@ -32,6 +32,10 @@ public override void OnException(ExceptionContext context)
             {
                 context.Result = new ObjectResult(ProblemDetailsUtils.GenerateProblemDetails(context.Exception, GitErrorCodes.GiteaSessionExpired, HttpStatusCode.Unauthorized)) { StatusCode = (int)HttpStatusCode.Unauthorized };
             }
+            if (context.Exception is LibGit2SharpException && context.Exception.Message.Contains("server requires authentication that we do not support"))
+            {
+                context.Result = new ObjectResult(ProblemDetailsUtils.GenerateProblemDetails(context.Exception, GitErrorCodes.GiteaSessionExpired, HttpStatusCode.Unauthorized)) { StatusCode = (int)HttpStatusCode.Unauthorized };
+            }
         }
     }
 }
diff --git a/backend/src/Designer/Services/Implementation/SourceControlLoggingDecorator.cs b/backend/src/Designer/Services/Implementation/SourceControlLoggingDecorator.cs
@@ -171,15 +171,6 @@ public void FetchRemoteChanges(string org, string repository)
             {
                 _decoratedService.FetchRemoteChanges(org, repository);
             }
-            catch (LibGit2Sharp.LibGit2SharpException libGit2SharpException)
-            {
-                if (libGit2SharpException.Message.Contains("server requires authentication that we do not support"))
-                {
-                    throw new GiteaUnathorizedException("Gitea session is invalid.");
-                }
-
-                throw;
-            }
             catch (Exception ex)
             {
                 LogError(ex, "FetchRemoteChanges", org, repository);