Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/10916 resourceadm translation #10933

Merged
11 commits merged into from
Aug 29, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2023

Description

Added translation to all files except Migration files because it is still a bit unclear how this page will be.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ghost ghost requested a review from framitdavid August 28, 2023 13:12
@ghost ghost self-assigned this Aug 28, 2023
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 70.00% and no project coverage change.

Comparison is base (63ba7a9) 76.32% compared to head (08bab5c) 76.33%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10933   +/-   ##
=======================================
  Coverage   76.32%   76.33%           
=======================================
  Files         588      588           
  Lines       10037    10035    -2     
  Branches     1336     1333    -3     
=======================================
- Hits         7661     7660    -1     
  Misses       2162     2162           
+ Partials      214      213    -1     
Files Changed Coverage Δ
...d/resourceadm/utils/resourceUtils/resourceUtils.ts 66.66% <70.00%> (+1.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 I have a few comments to be considered. 😄

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@ghost ghost merged commit fc09b42 into master Aug 29, 2023
7 of 8 checks passed
@ghost ghost deleted the feature/10916-resourceadm-translation branch August 29, 2023 06:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅✅Closed
Development

Successfully merging this pull request may close these issues.

2 participants