-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/10916 resourceadm translation #10933
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #10933 +/- ##
=======================================
Coverage 76.32% 76.33%
=======================================
Files 588 588
Lines 10037 10035 -2
Branches 1336 1333 -3
=======================================
- Hits 7661 7660 -1
Misses 2162 2162
+ Partials 214 213 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀 I have a few comments to be considered. 😄
frontend/resourceadm/components/ResourceDeployStatus/ResourceDeployStatus.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceDeployStatus/ResourceDeployStatus.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceNameAndId/ResourceNameAndId.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceNameAndId/ResourceNameAndId.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceNameAndId/ResourceNameAndId.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceTable/ResourceTableDataRow/ResourceTableDataRow.tsx
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceTable/ResourceTableDataRow/ResourceTableDataRow.tsx
Show resolved
Hide resolved
frontend/resourceadm/pages/DeployResourcePage/DeployResourcePage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚀
Description
Added translation to all files except
Migration files
because it is still a bit unclear how this page will be.Related Issue(s)
Verification
Documentation