Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to app deployment status #11410

Merged
merged 3 commits into from
Nov 5, 2023
Merged

updates to app deployment status #11410

merged 3 commits into from
Nov 5, 2023

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Oct 21, 2023

Description

Backend:

  • Updated code that sets status to failed for old builds that no longer exist in AzureDevOps to include a finished time.

Frontend:

  • Updated appDeploymentComponent to handle the case where deployment status could not be fetched (because it's old and missing from AzureDevOps), but the version is available in the environment (deployedToEnv=true), indicating that the actual deployment was
    successful. In that case, a warning message is shown: Screenshot 2023-10-21 at 22 25 54
  • Updated some toast behaviour that seems strange to me. The old current behaviour is that if the LAST deployment to an environment has failed, you get a generic toast warning that something has gone wrong. This makes it hard for the user to understand if something has failed on the page or not.
    • I added a check for the type of error - if the user gets some error on the mutation itself, then a generic error message might be the correct response. If the user just has a failed deployment as the last deployment, they should get a more detailed message specifying exactly that instead of the generic one. Screenshot 2023-10-21 at 22 40 14

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e18aeeb) 83.42% compared to head (8b1226d) 83.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11410   +/-   ##
=======================================
  Coverage   83.42%   83.43%           
=======================================
  Files         870      870           
  Lines       12920    12929    +9     
  Branches     1699     1705    +6     
=======================================
+ Hits        10779    10787    +8     
  Misses       1882     1882           
- Partials      259      260    +1     
Files Coverage Δ
...s/appPublish/components/appDeploymentComponent.tsx 92.06% <90.90%> (-0.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard area/pdf solution/platform Issues related to Altinn Platform solutions. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 5, 2023
Copy link

sonarcloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot removed area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard area/pdf solution/platform Issues related to Altinn Platform solutions. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 5, 2023
@nkylstad nkylstad merged commit 33bf034 into master Nov 5, 2023
15 checks passed
@nkylstad nkylstad deleted the bug/fix-deployment-status branch November 5, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants