Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing PagesRouter to navigate between packages #11883

Merged
5 commits merged into from
Dec 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2023

Description

  • Implementing a class to navigate between different packages in studio

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99fa433) 86.35% compared to head (84d2309) 86.37%.
Report is 1 commits behind head on master.

Files Patch % Lines
frontend/app-development/layout/PageHeader.tsx 50.00% 2 Missing ⚠️
...rc/components/AppBarConfig/AppPreviewBarConfig.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11883      +/-   ##
==========================================
+ Coverage   86.35%   86.37%   +0.01%     
==========================================
  Files         903      904       +1     
  Lines       12947    12957      +10     
  Branches     1616     1620       +4     
==========================================
+ Hits        11181    11191      +10     
  Misses       1534     1534              
  Partials      232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 👏 I have a few suggestions. 😊

@ghost ghost requested a review from framitdavid December 18, 2023 18:07
@ghost ghost merged commit 705fb4c into master Dec 19, 2023
9 of 10 checks passed
@ghost ghost deleted the feature/11447-navigate-between-packages branch December 19, 2023 11:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create functionality to navigate from a route in one package to a route in another package
2 participants