Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11493/cypress tests settings modal #11884

Merged
merged 2 commits into from
Dec 19, 2023
Merged

11493/cypress tests settings modal #11884

merged 2 commits into from
Dec 19, 2023

Conversation

nkylstad
Copy link
Member

Description

Added cypress tests for the settings modal.
Included tabs:

  • Overview/app name
  • App settings
  • Policy editor (only loading, no testing of the actual functionality)
  • Access control
  • Local changes

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@nkylstad nkylstad marked this pull request as ready for review December 18, 2023 13:24
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Dec 18, 2023
@nkylstad nkylstad linked an issue Dec 18, 2023 that may be closed by this pull request
Add cypress tests for settings modal #11493
Closed
TomasEng
TomasEng approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ryddig!

@nkylstad nkylstad merged commit 55f6bc0 into master Dec 19, 2023
3 checks passed
@nkylstad nkylstad deleted the 11493/cypress-tests-settings-modal branch December 19, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasEng TomasEng TomasEng approved these changes

Assignees
No one assigned
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cypress tests for settings modal
2 participants
@nkylstad @TomasEng