Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align datamodel field rows correctly #11892

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Align datamodel field rows correctly #11892

merged 1 commit into from
Dec 19, 2023

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Dec 19, 2023

Description

Set vertical-align to top so that the fields are aligned even when there is an error message:

image

The design system components will always have the same height, so there is no need for center alignment.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99fa433) 86.35% compared to head (75bbc36) 86.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11892   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         903      903           
  Lines       12947    12947           
  Branches     1616     1616           
=======================================
  Hits        11181    11181           
  Misses       1534     1534           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng linked an issue Dec 19, 2023 that may be closed by this pull request
@TomasEng TomasEng marked this pull request as ready for review December 19, 2023 08:28
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@TomasEng TomasEng merged commit d77979f into master Dec 19, 2023
10 checks passed
@TomasEng TomasEng deleted the align-field-rows branch December 19, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment issues on fields configuration
2 participants