Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ContainerTool): Support both Podman and Docker as container tool for setup-script #12194

Closed
wants to merge 34 commits into from

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Jan 29, 2024

Description

Added support for using Podman as an alternative container tool through the setup.js script, which configures the environment in Studio.

Step By Step Setup

  1. Confirm the Docker Engine is inactive.
  2. Download Podman Desktop and execute the installation process.
  3. Follow the instruction by the Podman installer.
  4. Ensure to add 127.0.0.1 host.docker.internal to your hosts file.
  5. Execute yarn setup within the root directory of the Altinn Studio Repository.
  6. Please ensure everything is functioning properly by accessing studio.localhost, logging in, and making changes to the dashboard to confirm that the page reloads with the latest updates.

Related Issue(s)

The PR itself.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@framitdavid framitdavid marked this pull request as draft January 29, 2024 21:47
@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Jan 29, 2024
@framitdavid framitdavid changed the title feat(Container): Support both Podman and Docker as container tool feat(ContainerTool): Support both Podman and Docker as container tool Jan 29, 2024
@framitdavid framitdavid self-assigned this Jan 29, 2024
@framitdavid framitdavid changed the title feat(ContainerTool): Support both Podman and Docker as container tool feat(ContainerTool): Support both Podman and Docker as container tool for setup-script Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb9e666) 86.43% compared to head (c93c90f) 86.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12194   +/-   ##
=======================================
  Coverage   86.43%   86.44%           
=======================================
  Files        1198     1198           
  Lines       18080    18080           
  Branches     2295     2295           
=======================================
+ Hits        15628    15629    +1     
+ Misses       2166     2165    -1     
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Feb 6, 2024
@ghost ghost closed this Apr 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant