Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong uri in task extension #12231

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Feb 1, 2024

Description

The URI referenced http://altinn.no, but should have referenced http://altinn.no/process. This resulted i 2 competing namespaces for processes which already had the http://altinn.no/process namespace.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d3add3) 86.42% compared to head (e9d1c01) 86.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12231   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files        1188     1188           
  Lines       18045    18045           
  Branches     2290     2290           
=======================================
  Hits        15595    15595           
  Misses       2163     2163           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad added the kind/bug Used when there is a defect / something is not working as it should. label Feb 1, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM😄

@nkylstad nkylstad merged commit f3a7d5d into main Feb 1, 2024
11 checks passed
@nkylstad nkylstad deleted the bug/wrong-uri-process-extensions branch February 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant