Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12180 default section for component config #12232

Merged
20 commits merged into from
Feb 9, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2024

Description

  • Moving the edit component id and edit datamodel on component sections to the new default section for showing component config details.
Skjermbilde 2024-02-01 kl  17 20 16

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ghost ghost marked this pull request as draft February 1, 2024 16:26
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (97fef76) 86.42% compared to head (99e8e74) 86.39%.

Files Patch % Lines
...Header/DataModelBindingRow/DataModelBindingRow.tsx 85.71% 0 Missing and 1 partial ⚠️
...s/Properties/PropertiesHeader/PropertiesHeader.tsx 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12232      +/-   ##
==========================================
- Coverage   86.42%   86.39%   -0.04%     
==========================================
  Files        1192     1198       +6     
  Lines       18067    18097      +30     
  Branches     2292     2295       +3     
==========================================
+ Hits        15614    15634      +20     
- Misses       2164     2173       +9     
- Partials      289      290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost marked this pull request as ready for review February 5, 2024 08:38
@ghost ghost linked an issue Feb 5, 2024 that may be closed by this pull request
@ghost
Copy link
Author

ghost commented Feb 5, 2024

The failing test, Frontend Tests / Testing (push) is failing because Codecov is unable to upload the report.

@ghost ghost requested a review from TomasEng February 9, 2024 12:37
@ghost ghost merged commit e6b8382 into main Feb 9, 2024
10 of 11 checks passed
@ghost ghost deleted the 12180-default-section-for-component-config branch February 9, 2024 13:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the default section for component config
2 participants