Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix the two broken playwright tests #12255

Merged
5 commits merged into from
Feb 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2024

Description

  • Adding timeout to the SettingsModal test
  • Fixing the navigation app so that the user searches for the ttd app. The issue was that in dev, ttd has a lot of apps, but locally ttd has no apps. This resulted in the new app not being present on screen.

Related Issue(s)

  • The PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a0eceb) 86.42% compared to head (a6f0e74) 86.41%.
Report is 1 commits behind head on main.

❗ Current head a6f0e74 differs from pull request most recent head 31846c9. Consider uploading reports for the commit 31846c9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12255      +/-   ##
==========================================
- Coverage   86.42%   86.41%   -0.01%     
==========================================
  Files        1188     1188              
  Lines       18049    18049              
  Branches     2292     2292              
==========================================
- Hits        15598    15597       -1     
- Misses       2163     2164       +1     
  Partials      288      288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost merged commit f73ce31 into main Feb 6, 2024
9 checks passed
@ghost ghost deleted the Trying-to-fix-the-two-broken-Playwright-tests branch February 6, 2024 13:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants