Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PolicyCard): Ensure accurate label display within role options select #12348

Merged
merged 11 commits into from
Feb 21, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Feb 20, 2024

Description

Ensure accurate label display within role options select, subject title instead of subject id.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Feb 20, 2024
@framitdavid framitdavid marked this pull request as draft February 20, 2024 11:56
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (360a28a) 86.51% compared to head (d66152d) 86.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12348      +/-   ##
==========================================
+ Coverage   86.51%   86.56%   +0.05%     
==========================================
  Files        1199     1199              
  Lines       18057    18056       -1     
  Branches     2287     2286       -1     
==========================================
+ Hits        15622    15631       +9     
+ Misses       2150     2141       -9     
+ Partials      285      284       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@framitdavid framitdavid merged commit 379b392 into main Feb 21, 2024
11 checks passed
@framitdavid framitdavid deleted the fix/displayCorrectLabelWithinSelectList branch February 21, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant