Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused npm packages #12699

Merged
merged 15 commits into from
Jun 7, 2024
Merged

Removed unused npm packages #12699

merged 15 commits into from
Jun 7, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Apr 23, 2024 •
edited
Loading

Description

Removed several packages that were not used and were being updated by Renovate

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. kind/dependencies Used for issues or pull requests that are dependency updates labels Apr 23, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (6258b3b) to head (9b88f7d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12699   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files        1396     1396           
  Lines       19751    19751           
  Branches     2391     2391           
=======================================
  Hits        17988    17988           
  Misses       1501     1501           
  Partials      262      262

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. labels May 13, 2024
@mlqn mlqn marked this pull request as ready for review June 5, 2024 08:28
@mlqn mlqn added the skip-releasenotes Issues that do not make sense to list in our release notes label Jun 5, 2024
ghost
ghost approved these changes Jun 7, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@mlqn mlqn merged commit bf84169 into main Jun 7, 2024
11 checks passed
@mlqn mlqn deleted the chore/cleanup-npm-packages branch June 7, 2024 07:38
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
@mlqn @Jondyr
Removed unused npm packages (#12699)
b4adcb6 
* Removed some unused npm packages

* Remove more unused npm packages

* Removed some unused npm packages

* Remove unused packages

* Remove material from schema-editor

* Update yarn.lock file

* Remove Redux from shared

* Remove unused packages

* Update yarn.lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlqn