Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10469 should fetch actual footer layout if it exists #12843

Merged
merged 4 commits into from
Jun 6, 2024
Merged

10469 should fetch actual footer layout if it exists #12843

merged 4 commits into from
Jun 6, 2024

Conversation

standeren
Copy link
Contributor

Description

Update endpoint in previewController to fetch actual footer in app if present and return Ok if not found.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue May 24, 2024 that may be closed by this pull request
Should fetch actual footer layout if it exists #10469
Closed
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels May 24, 2024
@standeren standeren force-pushed the 10469-should-fetch-actual-footer-layout-if-it-exists branch from a99c899 to 00571f1 Compare May 24, 2024 08:12
nkylstad
nkylstad requested changes May 26, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Footer class does not seem to match the JSONSchema definition entirely, see the comments 😊

backend/src/Designer/Models/FooterFile.cs Outdated Show resolved Hide resolved
backend/tests/Designer.Tests/Controllers/PreviewController/GetFooterTests.cs Show resolved Hide resolved
nkylstad
nkylstad requested changes May 30, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below on the FooterFile class and related classes 😊

backend/src/Designer/Models/FooterFile.cs Show resolved Hide resolved
backend/src/Designer/Models/FooterFile.cs Outdated Show resolved Hide resolved
backend/src/Designer/Models/FooterFile.cs Outdated Show resolved Hide resolved
nkylstad
nkylstad requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just one comment regarding namespacing that I didn't catch the first time around 🙈

backend/src/Designer/Models/FooterFile.cs Show resolved Hide resolved
@standeren standeren force-pushed the 10469-should-fetch-actual-footer-layout-if-it-exists branch from 157ac9c to bd78b85 Compare June 4, 2024 11:18
nkylstad
nkylstad approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@standeren standeren merged commit 06facb5 into main Jun 6, 2024
10 checks passed
@standeren standeren deleted the 10469-should-fetch-actual-footer-layout-if-it-exists branch June 6, 2024 07:13
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
@standeren @Jondyr
10469 should fetch actual footer layout if it exists (#12843)
0dbd849 
* Add endpoint in preview to get footer

* Add tests

* Fix PR comments

* Simplify Footer definition class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

Assignees
No one assigned
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should fetch actual footer layout if it exists
2 participants
@standeren @nkylstad