refactor(ProcessEditor): Decouple integration with BFF when adding tasks in the process editor. #12894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same for remove mutations
framitdavid
added
the
skip-releasenotes
github-actions
bot
added
area/process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12894 +/- ##
==========================================
- Coverage 91.07% 91.06% -0.01%
==========================================
Files 1396 1393 -3
Lines 19751 19732 -19
Branches 2391 2389 -2
==========================================
- Hits 17988 17969 -19
Misses 1501 1501
Partials 262 262 ☔ View full report in Codecov by Sentry. |
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskAddHandler.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskAddHandler.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskAddHandler.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskRemoveHandler.test.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskRemoveHandler.test.ts
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskRemoveHandler.test.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskRemoveHandler.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
frontend/app-development/hooks/mutations/useAddLayoutSetMutation.ts
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 4, 2024
ghost
assigned …altinn-studio into feat/refacsProcessEditor
Thanks! I have answered some of your comments and fixed some! Assigning the review back to you. :) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
frontend/app-development/features/processEditor/handlers/OnProcessTaskAddHandler.test.ts
Fixed
Show fixed
Hide fixed
ghost
reviewed
Jun 5, 2024
frontend/app-development/features/processEditor/handlers/OnProcessTaskAddHandler.test.ts
Show resolved
Hide resolved
github-actions
bot
added
the
quality/testing
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
…sks in the process editor. (#12894) refactor(ProcessEditor): Decouple integration with BFF when adding tasks in the process editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing cleaning up the process editor to make it more independent of domain knowledge when adding events. When tasks such as payment are added, the app development controls which API calls and side effects should be carried out.
We still need to refine the handling of custom receipts, which will likely need to be changed in a separate PR. But after that, I think we can avoid passing React Query methods down to the process-editor package, which means that we might delete the BpmnApiContext afterwards!
Added skip-releasenotes on this one, since its refactoring only.
Related Issue(s)
Verification