-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ProcessEditor): SelectDataType should append current selected value to the option list #12933
Conversation
…ue to the option list
Added skip-releasenotes because this bug was never shipped to production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a unit test for this scenario? Since this is a blocker for deploy we should merge it asap, but maybe a separate pr with a test or two if that's possible 😊
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12933 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 1394 1394
Lines 19757 19758 +1
Branches 2394 2395 +1
=======================================
+ Hits 18002 18003 +1
Misses 1493 1493
Partials 262 262 ☔ View full report in Codecov by Sentry. |
Just added one test for it now! :) |
…m/Altinn/altinn-studio into fix/selectDatamodelShouldNotCrash
Tested ok i dev |
…ue to the option list (#12933) * fix(ProcessEditor): SelectDataType should append current selected value to the option list
Description
If the previously selected data type did not exist in the list of available data types, the combo box would crash. I resolved this by checking if the selected value exists and adding it to the list of available options.
Related Issue(s)
Verification