Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11360 cleanup error message components #13237

Merged
merged 14 commits into from
Aug 2, 2024

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Jul 26, 2024

Description

Added a reusable StudioPageError component to @Studio/components to use it instead of different error types. This component will return the alert from the design system.

Changes:

  • Added a test file.
  • Added a CSS file.
  • Added StudioPageError.stories.tsx.
  • Added StudioPageError.mdx.
  • Removed the old ErrorPage component along with its related index and CSS files because it has been replaced with
    StudioPageError.
  • Reused StudioPageError in relevant places.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Jul 26, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (a7b02a2) to head (d3020e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13237   +/-   ##
=======================================
  Coverage   93.61%   93.62%           
=======================================
  Files        1423     1421    -2     
  Lines       19815    19803   -12     
  Branches     2402     2402           
=======================================
- Hits        18550    18540   -10     
+ Misses       1015     1013    -2     
  Partials      250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng
Copy link
Contributor

Denne branchen henger litt etter master nå. Kan du oppdatere den, @JamalAlabdullah?

@JamalAlabdullah
Copy link
Contributor Author

Denne branchen henger litt etter master nå. Kan du oppdatere den, @JamalAlabdullah?

Oppdatert nå 👍

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fin opprydning.

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utmerket!

@JamalAlabdullah JamalAlabdullah merged commit 51e1dd5 into main Aug 2, 2024
8 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 11360-cleanup-error-message-components branch August 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup error message components
2 participants