-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11360 cleanup error message components #13237
Conversation
…essage-components
…essage-components
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13237 +/- ##
=======================================
Coverage 93.61% 93.62%
=======================================
Files 1423 1421 -2
Lines 19815 19803 -12
Branches 2402 2402
=======================================
- Hits 18550 18540 -10
+ Misses 1015 1013 -2
Partials 250 250 ☔ View full report in Codecov by Sentry. |
Denne branchen henger litt etter master nå. Kan du oppdatere den, @JamalAlabdullah? |
Oppdatert nå 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fin opprydning.
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.module.css
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.module.css
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.mdx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Utmerket!
Description
Added a reusable
StudioPageError
component to@Studio/components
to use it instead of different error types. This component will return the alert from the design system.Changes:
StudioPageError.stories.tsx.
StudioPageError.mdx.
ErrorPage
component along with its related index and CSS files because it has been replaced withStudioPageError.
StudioPageError
in relevant places.Related Issue(s)
Verification
Documentation