-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation for the number of characters in the name of the receipt #13294
Added validation for the number of characters in the name of the receipt #13294
Conversation
…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13294 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 1438 1438
Lines 19924 19926 +2
Branches 2417 2418 +1
=======================================
+ Hits 18670 18672 +2
Misses 1006 1006
Partials 248 248 ☔ View full report in Codecov by Sentry. |
…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @JamalAlabdullah! Could you please add a unit test for this fix to ensure it doesn't happen again in the future?
…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 👏 Have you had a chance to test this manually? It seems like the checkbox in the PR description hasn't been checked yet.
Description
Related Issue(s)
Verification
Documentation