Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for the number of characters in the name of the receipt #13294

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Aug 5, 2024

Description

  • Added a validation fot hte number of characters in the name of the receipt.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 5, 2024
…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (eece61b) to head (9f52fcf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13294   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files        1438     1438           
  Lines       19924    19926    +2     
  Branches     2417     2418    +1     
=======================================
+ Hits        18670    18672    +2     
  Misses       1006     1006           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…pears-when-giving-a-custom-receipt-a-name-with-only-one-character
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @JamalAlabdullah! Could you please add a unit test for this fix to ensure it doesn't happen again in the future?

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏 Have you had a chance to test this manually? It seems like the checkbox in the PR description hasn't been checked yet.

@JamalAlabdullah JamalAlabdullah merged commit 094f359 into main Aug 16, 2024
8 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13118-danger-toast-appears-when-giving-a-custom-receipt-a-name-with-only-one-character branch August 16, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Danger toast appears when giving a custom receipt a name with only one character
2 participants