Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor setup script #13323

Merged
merged 18 commits into from
Aug 8, 2024
Merged

refactor setup script #13323

merged 18 commits into from
Aug 8, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Aug 8, 2024
@framitdavid framitdavid self-requested a review August 8, 2024 10:45
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Aug 8, 2024
},
module.exports = async (options) => {
try {
const response = await fetch(`${options.hostname || 'http://localhost:3000'}${options.path}`, {

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
}
req.end(() => {});
});
body: options.body ? JSON.stringify(options.body) : undefined,

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (a816a4f) to head (de9a403).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13323   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files        1424     1424           
  Lines       19864    19864           
  Branches     2412     2412           
=======================================
  Hits        18600    18600           
  Misses       1015     1015           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, hope its okay since we did this together with pair-programming. 🙈

@mirkoSekulic mirkoSekulic merged commit 222bba6 into main Aug 8, 2024
2 checks passed
@mirkoSekulic mirkoSekulic deleted the refactor/setup-script branch August 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants